Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined update #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Combined update #10

wants to merge 2 commits into from

Conversation

mrtcode
Copy link
Member

@mrtcode mrtcode commented Jul 12, 2017

No description provided.

@mrtcode
Copy link
Member Author

mrtcode commented Jul 13, 2017

The overview of the most important changes made to arkivo, zotero-api-node, stream-server.

arkivo

  • Implemented a reliable resubscribe, resync logic which also resulted in various Arkivo architecture changes. The main idea is that what it does on restart and what it does on stream-server reconnect is basically the same except that on restart it firstly finishes the unfinished jobs. Now it has a consistent and predictable main loop.
  • Now Arkivo firstly subscribes to stream-server and only then does the sync. Previously it was opposite which could result in missed updates and not triggered sync.
  • No more waiting for stream-server responses to return success/failure to client on subscription creation. Instead we just simply request the provided items URL with the key, and then check the response. Previously it was not returning any response if stream-server was restarted.
  • Handles zotero-api-node stream errors and doesn't crash on various connection errors.
  • Increased versions URL limit to 5000 which makes library sync much faster.
  • Fixed a bug for plugins that use a callback.
  • Solved node_redis deprecation warnings.
  • Added support for relative plugin paths.
  • Documented Arkivo re(sync), stream re(subscribe), subscription creation and removal flows, which will be helpful for further development.

zotero-api-node

  • Now always reconnects, if zotero-api-node errors are handled (by Arkivo).
  • Disabled resubscribe, because it has bugs and architectual issues.

stream-server

  • Returns an error event instead of closing connection and killing all other subscriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant