Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie tests fail in different locales #65

Closed
mgedmin opened this issue Feb 5, 2019 · 0 comments
Closed

Cookie tests fail in different locales #65

mgedmin opened this issue Feb 5, 2019 · 0 comments

Comments

@mgedmin
Copy link
Member

mgedmin commented Feb 5, 2019

tox -e docs fails for me. They pass for me (given #64) if I set LC_TIME=C instead of my usual lt_LT.UTF-8.

I suspect expires.strftime('%a, %d %b %Y %H:%M:%S GMT') in zope.testbrowser.cookies is not really what we want to.
mgedmin added a commit that referenced this issue Feb 5, 2019
@mgedmin
Cookie expiration dates should be locale-independent
3ad375b 
Incidentally sphinx-build doctest does call locale.setlocale() which
expolains why the cookie narrative tests always failed on my machine.

Fixes #65.
@mgedmin mgedmin mentioned this issue Feb 5, 2019
Merged
mgedmin added a commit that referenced this issue Feb 5, 2019
@mgedmin
Cookie expiration dates should be locale-independent
632e29b 
Incidentally sphinx-build doctest does call locale.setlocale() which
expolains why the cookie narrative tests always failed on my machine.

Fixes #65.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgedmin