Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests break with multipart >= 1.0 #74

Closed
Tracked by #100
icemac opened this issue Sep 24, 2024 · 1 comment · Fixed by #75
Closed
Tracked by #100

Tests break with multipart >= 1.0 #74

icemac opened this issue Sep 24, 2024 · 1 comment · Fixed by #75
Labels
enhancement

Comments

@icemac
Copy link
Member

icemac commented Sep 24, 2024

There were several version updates but I bisected the broken tests at https://github.com/zopefoundation/zope.publisher/actions/runs/10980975705/job/30487442606 to multipart >= 1.
@icemac icemac mentioned this issue Sep 24, 2024
Open
6 tasks
@mgedmin
Copy link
Member

mgedmin commented Sep 24, 2024

I just filed defnull/multipart#55 about this, after debugging my application all morning.

I have a local fix for the line ending issue, but the lack of SpooledTemporaryFile.seekable() breaks one remaining test case on Pythons 3.8 through 3.10.

mgedmin added a commit that referenced this issue Sep 24, 2024
@mgedmin
Use CRLF line endings in tests
a44be99 
The new parser in multipart 1.0.0 requires CRLF rather than LF line
endings: defnull/multipart#55

Fixes most of #74.  The one remaining failure is a regression of #44
(lack of `.seekable()` on FileUpload objects).
@mgedmin mgedmin mentioned this issue Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for multipart 1.0.0 zopefoundation/zope.publisher
2 participants
@mgedmin @icemac