-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring for pure-python #15
Conversation
@jamadden Do you have an idea what causes these errors? Could it be because there is no final release of |
I suppose it's possible? I can't reproduce it locally after trying a couple different ways. What happens if you add |
Seeing the same error locally. @jamadden What was the reason again to release
|
There was some risk, but the main reason was to get an answer to zopefoundation/zope.interface#236: We've changed a |
This buildout failure will hit every single buildout that doesn't pin the version for zope.component. IMHO that's a bigger problem than having to change doctests. If the decision was up to me I'd release zope.interface ASAP. |
Since none of the zopetoolkit packages had any issues with the changed repr, my concern about having to change doctests twice is lessened, but I haven't tried to test any higher level packages. I have no problem with making a final release, but I can't today, I'm away from the computer with family for my youngest niece's birthday. If someone else wanted to, that's fine with me. |
Uploaded. Thank you.
… On Mar 21, 2021, at 05:12, Jens Vagelpohl ***@***.***> wrote:
@jamadden Have fun!
@icemac Looks like the GitHub actions created and uploaded all wheels and only the sdist is missing. I am not a zope.interface maintainer but you are. Could you make me maintainer or create/upload the sdist from the 5.3.0 tag? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@dataflake I've sent you an invitation on PyPI. |
It seems that the final release of |
- Add support for Python 3.7, 3.9 and 3.9. - Drop support for Python 3.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
Thank you for reviewing this PR. 😃 |
First attempt. Locally the shpinx doctests break for all Python versions. In GHA only the Python 2 bases ones seem to have a problem.