Port to Python 3 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadden
force-pushed
the
python3
branch
2 times, most recently
from
94e04c3
to
05da517
Compare
jamadden
added a commit
to zopefoundation/zope.file
that referenced
this pull request
Apr 21, 2017
The tests pass, but they need unreleased versions of zope.app.basicskin (zopefoundation/zope.app.basicskin#1) and zope.app.pagetemplate (zopefoundation/zope.app.pagetemplate#1). We also have a workaround for zopefoundation/zope.mimetype#6 (no issue/fix yet) and the unreleased zopefoundation/zope.publisher#13
tseaver
requested changes
Apr 21, 2017
setup.py
Outdated
| 'License :: OSI Approved :: Zope Public License', | ||
| 'Programming Language :: Python', | ||
| 'Programming Language :: Python:: 2.7', | ||
| 'Programming Language :: Python:: 3.5', |
| """ | ||
| from __future__ import print_function, absolute_import, division |
| @@ -15,9 +15,10 @@ | |||
|
|
|||
| $Id$ | |||
| """ | |||
| from __future__ import print_function, absolute_import, division | |||
| """ | ||
| Tests for deprecated/backwards-compatibility imports. | ||
| """ | ||
| from __future__ import print_function, absolute_import, division |
| """ | ||
| from __future__ import print_function, absolute_import, division |
| >>> api = ZopeTalesAPI(testObject) | ||
| >>> api.created | ||
| datetime.datetime(2000, 10, 1, 23, 11) | ||
| """ |
There was a problem hiding this comment.
There were few enough doctests here that I was able to get away with not using a RENormalizer and just convert to unit tests 😄
| """ | ||
|
|
||
| from __future__ import absolute_import, print_function, division |
| """ | ||
| from __future__ import print_function, absolute_import, division |
mgedmin
approved these changes
Apr 22, 2017
.travis.yml
Outdated
| script: | ||
| - python setup.py test -q | ||
| - coverage run -m zope.testrunner --test-path=src --auto-color --auto-progress |
There was a problem hiding this comment.
My inner pedant cannot not notice the indentation change here.
|
Thanks! A PyPI release would be handy when convenient. |
|
@jamadden what's your PyPI username? |
@mgedmin It's... jamadden. I'm predictable. Mostly 😉 |
|
You now have PyPI rights to zope.app.pagetemplate. Congratulations! |
|
Cool, thanks. If there are no objections, I'll go ahead and release this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.