Exception : Unsupported ISO 3661 country: en (or xx)

[aaska]

Describe your environment

• react-native-localize version 1.0.1
• react-native version 0.58.3
• Target platform: Android
• Device, simulator - not sure if this is even possible on real world devices
• OS version - all
• Android only: buildToolsVersion : 28.0.3

How to repeat issue and example

On an emulator, use the dev tool : "Custom locale" and pickup any locale without a script (ie: en, fr, de...) instead of those with a script.

When launching an app using RNLocalize, you get the following exception :

Unsupported ISO 3166 country: en
getInstance
    Currency.java:139
getCurrencyCode
    RNLocalizeModule.java:165
getExported
    RNLocalizeModule.java:197
getConstants
    RNLocalizeModule.java:74
getConstants
    JavaModuleWrapper.java:136
run
    NativeRunnable.java
handleCallback
    Handler.java:789
dispatchMessage
    Handler.java:98
dispatchMessage
    MessageQueueThreadHandler.java:29
loop
    Looper.java:164
run
    MessageQueueThreadImpl.java:192
run
    Thread.java:764

I've discovered the issue when using the Pre-release reports with localization testing on the play store.

Solution

Sorry, I'm not sure what would be the best solution... eventually to default it to the first occurence of a local with a script ?

[zoontek]

@aaska Hi! I was not aware of this tool (Custom locale), is this https://play.google.com/store/apps/details?id=br.testing.locale&hl=en_US ?

It fails because you select a language without country code (which is not possible using Android settings menu) and so it is impossible to get a currency. But I can handle it with a fallback to USD.

[aaska]

@zoontek Thank you for your reply !

It's not an app I've downloaded, it's preloaded on Oreo's emulator's ROM -

Though, I've checked Pie's ROM and this app is not in there...

This is also what I think, it's not really a real world issue as you shouldn't be able to pickup a locale without the country, but if you use the pre-release reports of the play store and indicates some locales, it fails because of this issue :)

[zoontek]

@aaska I had multiple simulators and it was present on none of them 😅

I created an Orea ROM to fix the issue and released the 1.0.2 version: https://github.com/react-native-community/react-native-localize/releases/tag/1.0.2

Instead of keeping and handling an empty countryCode, I fallback to US (same for currencies and USD, for temperatureUnit, etc.), like I do on iOS (the only way to have an empty countryCode is to set a custom regionless Application Language and leave Application Region to System Region in Xcode settings).

This cases should never happen on real devices (on iOS 9+ and Android 4.1+), so I think it's better to enforce a default instead of return undefined

[mehrankhandev]

I have fixed the issue by changing code in react-native-node_modules/react-native-localize/android/src/main/java/com/reactcommunity/rnlocalize/RNLocalizeModule.java

Currency.getInstance(locale) throws exception For local "en_XA" . I have added try catch to fix the issue . Please replace function with below code

private static String getCurrencyCode(Locale locale, String fallback) {
    String countryCode = locale.getCountry();

    if (countryCode == null || countryCode.equals("")) {
      return fallback;
    }

    try {
      Currency currency = Currency.getInstance(locale);
      return currency == null ? fallback : currency.getCurrencyCode();
    } catch (Exception e) {
      return fallback;
    }

  }