-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classifier: Clean up TaskInput styling #6532
Conversation
<Markdownz>{status}</Markdownz> | ||
<StyledInputStatus> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This status is always strings of count and label provided by the tool models. No need for markdown.
margin-top: .5em; | ||
margin-bottom: .5em; | ||
align-items: center; | ||
min-height: 45px; | ||
margin: 8px 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Margin and padding are most useful as rigid units like px, not em or rem.
<StyledText> | ||
<Markdownz inline >{label}</Markdownz> | ||
<Markdownz inline>{label}</Markdownz> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Markdownz is needed because the label is controlled by project teams via the lab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the cleanup - LGTM!
Package
lib-classifier
Linked Issue and/or Talk Post
Follow-up on #6511. The task input's lost their min-height in that PR, so I've refactored the shared component's styling in this PR.
Describe your changes
How to Review
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Refactoring