Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib-classifier): submit previously transcribed lines on Enter #6410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Oct 28, 2024

Wrap the subtask popup in a form, so that the form data can be saved from the form's submit action. This allows the end user to submit dropdown selections by pressing Enter, rather than having to click the Save button.

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

  • lib-classifier

How to Review

Try it out on the incomplete transcription line in the dev classifier here. You can select an option with the cursor keys, then hit Enter once to select and twice to submit the form.
https://localhost:8080/?env=production&project=bmtcollections/documentation-detectives-transcribing-accession-registers&workflow=26197&subject=98054569

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

New Feature

  • The PR creator has listed user actions to use when testing the new feature
  • Unit tests are included for the new feature
  • A storybook story has been created or updated
    • Example of SlideTutorial component with docgen comments, and its story

Wrap the subtask popup in a form, so that the form data can be saved from the form's submit action. This allows the end user to submit dropdown selections by pressing Enter, rather than having to click the Save button.
@eatyourgreens eatyourgreens force-pushed the submit-transcribed-line-on-enter branch from a29e183 to f4d612f Compare October 28, 2024 10:40
@coveralls
Copy link

Coverage Status

coverage: 77.729%. remained the same
when pulling f4d612f on eatyourgreens:submit-transcribed-line-on-enter
into 856b3bc on zooniverse:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants