Removes old consistency05/06 unit tests #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
requested review from
mattias-p,
tgreenx,
marc-vanderwal and
MichaelTimbert
marc-vanderwal
approved these changes
Jul 9, 2024
tgreenx
approved these changes
Jul 9, 2024
matsduf
added
the
V-Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The unit tests that this PR removes depend on test zones that are about to be removed.
There are other unit tests for the two test cases in
t/Test-consistency05.tandt/Test-consistency06.t. There are, however, some bugs in the implementation of the two test cases that prevents the full utilization of those unit tests:Also see:
Those problems, however, should not prevent merging of this PR.
How to test this PR
The unit tests should pass.