Preparation for release v2024.1 (Engine) #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
requested review from
mattias-p,
tgreenx,
marc-vanderwal and
MichaelTimbert
|
CI will fail until zonemaster/zonemaster-ldns#191 has been merged. |
matsduf
force-pushed
the
preparation-release-v2024.1
branch
from
51dc3e5 to
53abb57
Compare
marc-vanderwal
previously approved these changes
Jul 1, 2024
MichaelTimbert
previously approved these changes
Jul 1, 2024
mattias-p
reviewed
Jul 1, 2024
| @@ -33,7 +33,7 @@ requires 'Net::IP::XS' => 0.21; | |||
| requires 'Readonly' => 0; | |||
| requires 'Text::CSV' => 0; | |||
| requires 'YAML::XS' => 0; | |||
| requires 'Zonemaster::LDNS' => 4.000000; # For v4.0.0 | |||
| requires 'Zonemaster::LDNS' => 4.000002; # For v4.0.2 | |||
There was a problem hiding this comment.
Wouldn't it be better to not bump this requirement?
There was a problem hiding this comment.
This is the way we have done every time and has decided to do.
Changes
Outdated
| [Features] | ||
|
|
||
| - Makes it possible to run single testcase via test_zone() (#1312) | ||
| - Changes supported way of extracting default profile (#1339) |
There was a problem hiding this comment.
This one is a breaking change.
There was a problem hiding this comment.
In what way is it breaking?
There was a problem hiding this comment.
To be honest I think it's rather silly to require users to reinstall Zonemaster-LDNS when upgrading Zonemaster-Engine just because we fixed some links in the README.
There was a problem hiding this comment.
If you use the recommended way of installation no effort is needed.
tgreenx
reviewed
Jul 1, 2024
matsduf
dismissed stale reviews from MichaelTimbert and marc-vanderwal
via
76d7cf1
matsduf
requested review from
mattias-p,
tgreenx,
MichaelTimbert and
marc-vanderwal
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
marc-vanderwal
previously approved these changes
Jul 1, 2024
tgreenx
reviewed
Jul 1, 2024
tgreenx
approved these changes
Jul 1, 2024
marc-vanderwal
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Preparation for release.
Changes
Updates files
Changes,Engine.pmandMakefile.PL.How to test this PR
Review the changes.