Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword messages when no response is received #1365

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Reword messages when no response is received #1365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Zonemaster/Engine/Test/Basic.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ Readonly my %TAG_DESCRIPTIONS => (
},
B02_NS_NO_RESPONSE => sub {
__x # BASIC:B02_NS_NO_RESPONSE
'Name server "{ns}" does not respond to an SOA query.', @_;
'No response received from name server "{ns}" to SOA query.', @_;
},
B02_UNEXPECTED_RCODE => sub {
__x # BASIC:B02_UNEXPECTED_RCODE
Expand Down
12 changes: 6 additions & 6 deletions lib/Zonemaster/Engine/Test/Connectivity.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,15 +190,15 @@ Readonly my %TAG_DESCRIPTIONS => (
},
CN01_NO_RESPONSE_NS_QUERY_UDP => sub {
__x # CONNECTIVITY:CN01_NO_RESPONSE_NS_QUERY_UDP
'Nameserver {ns} does not respond to NS queries over UDP.', @_;
'No response received from name server "{ns}" to NS queries over UDP.', @_;
},
CN01_NO_RESPONSE_SOA_QUERY_UDP => sub {
__x # CONNECTIVITY:CN01_NO_RESPONSE_SOA_QUERY_UDP
'Nameserver {ns} does not respond to SOA queries over UDP.', @_;
'No response received from name server "{ns}" to SOA queries over UDP.', @_;
},
CN01_NO_RESPONSE_UDP => sub {
__x # CONNECTIVITY:CN01_NO_RESPONSE_UDP
'Nameserver {ns} does not respond to any queries over UDP.', @_;
'No response received from name server "{ns}" to any queries over UDP.', @_;
},
CN01_NS_RECORD_NOT_AA_UDP => sub {
__x # CONNECTIVITY:CN01_NS_RECORD_NOT_AA_UDP
Expand Down Expand Up @@ -234,15 +234,15 @@ Readonly my %TAG_DESCRIPTIONS => (
},
CN02_NO_RESPONSE_NS_QUERY_TCP => sub {
__x # CONNECTIVITY:CN02_NO_RESPONSE_NS_QUERY_TCP
'Nameserver {ns} does not respond to NS queries over TCP.', @_;
'No response received from name server "{ns}" to NS queries over TCP.', @_;
},
CN02_NO_RESPONSE_SOA_QUERY_TCP => sub {
__x # CONNECTIVITY:CN02_NO_RESPONSE_SOA_QUERY_TCP
'Nameserver {ns} does not respond to SOA queries over TCP.', @_;
'No response received from name server "{ns}" to SOA queries over TCP.', @_;
},
CN02_NO_RESPONSE_TCP => sub {
__x # CONNECTIVITY:CN02_NO_RESPONSE_TCP
'Nameserver {ns} does not respond to any queries over TCP.', @_;
'No response received from name server "{ns}" to any queries over TCP.', @_;
},
CN02_NS_RECORD_NOT_AA_TCP => sub {
__x # CONNECTIVITY:CN02_NS_RECORD_NOT_AA_TCP
Expand Down
2 changes: 1 addition & 1 deletion lib/Zonemaster/Engine/Test/Zone.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ Readonly my %TAG_DESCRIPTIONS => (
},
Z01_MNAME_NO_RESPONSE => sub {
__x # ZONE:Z01_MNAME_NO_RESPONSE
'SOA MNAME name server "{ns}" does not respond to an SOA query.', @_;
'No response received from SOA MNAME name server "{ns}" to SOA query.', @_;
},
Z01_MNAME_NOT_AUTHORITATIVE => sub {
__x # ZONE:Z01_MNAME_NOT_AUTHORITATIVE
Expand Down