Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in B01_CHILD_IS_ALIAS msgid #1240

Conversation

marc-vanderwal
Copy link
Contributor

Purpose

This PR fixes a small typo in the msgid for B01_CHILD_IS_ALIAS.

Context

Found when preparing #1239.

Changes

Add a missing closing quotation mark after {ns_ip_list}.

How to test this PR

N/A.

A closing quotation mark is missing after “{ns_ip_list}”.
@marc-vanderwal marc-vanderwal added the V-Patch Versioning: The change gives an update of patch in version. label Jun 19, 2023
@marc-vanderwal marc-vanderwal added this to the v2023.1.1 milestone Jun 19, 2023
@marc-vanderwal marc-vanderwal requested review from mattias-p, matsduf, hannaeko, a user and tgreenx June 19, 2023 06:24
@marc-vanderwal
Copy link
Contributor Author

I suggest this be merged for the v2023.1.1 release instead of the v2023.1 release; otherwise we’d need to update all PO files again, which is disruptive.

@marc-vanderwal marc-vanderwal added the A-Translation Area: Documentation of, implementation of or actual translation of text label Jun 19, 2023
@matsduf
Copy link
Contributor

matsduf commented Jun 19, 2023

This will require updates of all PO files too, and will be taken in v2023.1.1.

@matsduf matsduf changed the base branch from develop to release-branch-v2023.1.1 June 29, 2023 09:23
@tgreenx tgreenx merged commit 1baf205 into zonemaster:releases/v2023.1.1 Jul 18, 2023
matsduf added a commit to matsduf/zonemaster-engine that referenced this pull request Jul 21, 2023
matsduf added a commit to matsduf/zonemaster-engine that referenced this pull request Jul 21, 2023
@marc-vanderwal marc-vanderwal deleted the bugfix/basic01-msgid-typo branch July 24, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Translation Area: Documentation of, implementation of or actual translation of text V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants