Avoid unnecessary calls to Profile::get in logger #1200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Store logfilter property instead of querying it at every method's call. This will improve performance.
Context
Taken from https://gitlab.rd.nic.fr/zonemaster/zonemaster-engine/-/commit/8b303b6c5d2e1a148c592325839256cc85f828b8
Credits to @blacksponge for the proposal
Changes
Logger.pm
How to test this PR
Tests should pass.
To assess the performance improvements, run:
And check that the time passed in the
_check_filter
routine has decreased.