Dockerfile: add build dependencies for Net::IP::XS #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out it was insufficient to just add Net::IP::XS to the list of packages to install in the Dockerfile. Because it’s the first XS package to be installed, it also requires GCC and the C header files for both Perl (for EXTERN.h) and musl libc (for sys/types.h).
marc-vanderwal
added
the
T-Bug
marc-vanderwal
requested review from
mattias-p,
matsduf,
hannaeko,
a user and
tgreenx
matsduf
approved these changes
Dec 5, 2022
tgreenx
approved these changes
Dec 5, 2022
mattias-p
approved these changes
Dec 5, 2022
matsduf
added
the
V-Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes an issue preventing the Docker image from being built.
It turns out it was insufficient to just add Net::IP::XS to the list of packages to install in the Dockerfile. Because it’s the first XS package to be installed, it also requires GCC and the C header files for both Perl (for EXTERN.h) and musl libc (for sys/types.h).
Context
Release testing for version 2022.2.
Changes
Add missing dependencies in Dockerfile
How to test this PR
Build the Docker image with
make docker-build. That operation should complete successfully.