Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup system messages #1142

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Cleanup system messages #1142

merged 2 commits into from
Oct 19, 2022

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Oct 14, 2022

Purpose

  1. Unused messages removed from various places.
  2. Messages missing in profile added to profile.

Context

See report in zonemaster/zonemaster#1105

How to test this PR

Review the changes and verify that no unit tests break.

@matsduf matsduf added this to the v2022.2 milestone Oct 14, 2022
@matsduf matsduf merged commit 6111d00 into zonemaster:develop Oct 19, 2022
@matsduf matsduf deleted the cleanup-system-messages branch October 19, 2022 09:55
@ghost ghost added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Dec 8, 2022
@ghost ghost mentioned this pull request Dec 8, 2022
Merged
@ghost
Copy link

ghost commented Dec 8, 2022 •
edited by ghost
Loading

It appears that the QUERY tag is still in use in the code, see

zonemaster-engine/lib/Zonemaster/Engine/Nameserver.pm

Lines 231 to 239 in 71d9198

Zonemaster::Engine->logger->add(
'query',
{
name => "$name",
type => $type,
flags => $href,
ip => $self->address->short
}
);

@matsduf matsduf added the V-Patch Versioning: The change gives an update of patch in version. label Dec 13, 2022
@matsduf
Copy link
Contributor Author

matsduf commented Dec 13, 2022

See #1164 for a partial revert of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgreenx tgreenx tgreenx approved these changes

@mattias-p mattias-p Awaiting requested review from mattias-p

@hannaeko hannaeko Awaiting requested review from hannaeko

@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal

Assignees
No one assigned
Labels
S-ReleaseTested Status: The PR has been successfully tested in release testing V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Milestone
v2022.2
Development

Successfully merging this pull request may close these issues.
2 participants
@matsduf @tgreenx