Fixes bug in Net::IP with a work around. Issue #1107

[matsduf]

Purpose

Net::IP does not make correct reverse name when last octet is a "0". This is a work-around the bug.

Context

Resolves #1107

How to test this PR

On a system where Net::IP::XS is not installed (e.g. CentOS 7) run the following command and verify that one of the last lines have a PTR query where the IP address ends with "0" and that the name is correct.

zonemaster-cli 15.248.151.in-addr.arpa --raw --show_testcase --test address/address02 --level DEBUG

[anandb-ripencc]

Can be fixed by explicitly installing Net::IP::XS

[matsduf]

Can be fixed by explicitly installing Net::IP::XS

The fix is still needed. Firstly, we know that the Docker installation is affected. It is unknown if the Rocky Linux is affected. Secondly, as long as Zonemaster supports running with Net::IP, which is an alternative dependency, the bug must be worked around.

[ghost]

as long as Zonemaster supports running with Net::IP

Couldn't Zonemaster depend on Net::IP::XS instead of Net::IP?

[matsduf]

Couldn't Zonemaster depend on Net::IP::XS instead of Net::IP?

Maybe. But as far as I can see Alpine Linux does not have any package with Net::IP::XS.

My solution is a work-around that I think the code should have as long as it uses Net::IP as an alternative dependency. If that is removed, the work-around is not needed.

[ghost]

But as far as I can see Alpine Linux does not have any package with Net::IP::XS.

Can't we install it from CPAN? It looks like we already install some packages from CPAN.

[matsduf]

Can't we install it from CPAN? It looks like we already install some packages from CPAN.

Possibly. When I saw the issue I also saw a simple work-around that would be safe add. If Net::IP is kept, I think the work-around is a correct solution, if Net::IP is dropped, the work-around is not needed and should not be kept or added.

[anandb-ripencc]

I don't understand the problem with the Docker image. In the Dockerfile, I see that you're installing some perl modules from packages, and then some directly from CPAN using cpanm. So you can just remove the perl-net-ip package, and instead add Net::IP::XS to the list of modules installed directly from CPAN.

To add to this discussion, our RIPE NCC Zonemaster build does NOT use any perl modules from the base distribution. We're using cpanm to install EVERYTHING into a perl local::lib directory. We do this, because we don't like mixing OS provided perl modules and CPAN provided perl modules, because it causes massive confusion.

To summarise, I think you should remove Net::IP as a dependency, and specify only Net::IP::XS as a dependency. If it's available as a package, a user can install it. Otherwise, it comes from CPAN.

[matsduf]

This is a work-around that is required if Net::IP is used. Nothing else.

[hannaeko]

To summarise, I think you should remove Net::IP as a dependency, and specify only Net::IP::XS as a dependency. If it's available as a package, a user can install it. Otherwise, it comes from CPAN.

I agree with this, even on a performance aspect Net::IP::XS performs way better, if we could have only this one as a dependency it would be nice.

[marc-vanderwal]

Looks good to me.

[anandb-ripencc]

This PR will be obsoleted once #1119 is merged, so it's better to close this. There's no need for this work-around.

[matsduf]

@mvw-afnic, can you review #1119 instead? When that is merged I will close this.

[matsduf]

Replaced by #1119

[marc-vanderwal]

Will do!