Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for umysqldb #264

Closed
jamadden opened this issue Jul 4, 2019 · 0 comments
Closed

Drop support for umysqldb #264

jamadden opened this issue Jul 4, 2019 · 0 comments
Assignees
Milestone

Comments

@jamadden
Copy link
Member

jamadden commented Jul 4, 2019

The driver is Python 2 only. It has some known buffer bugs that require a not-on-PyPI fork to resolve. There are a number of workarounds in the code for other weird things it has done.

But the killer is that in the work for #125, it's been discovered that it doesn't properly support SELECT...FOR UPDATE statements that timeout, either because of a 'NOWAIT' clause or because they hit the innodb_lock_timeout time. It just hangs there. Not good.

The gevent MySQLdb driver is the suggested replacement. In our test environments, so far it's doing at least as good as umysqldb.

@jamadden jamadden added this to the 3.0 milestone Jul 4, 2019
jamadden added a commit that referenced this issue Jul 4, 2019
…ON innodb_lock_timeout', which means 'nowait' doesn't work.

But even on MySQL 8, where we use the NOWAIT native syntax, it doesn't appear to be properly timing out. See #264.
@jamadden jamadden self-assigned this Jul 8, 2019
jamadden added a commit to NextThought/umysqldb that referenced this issue Jul 8, 2019
jamadden added a commit to NextThought/ultramysql that referenced this issue Jul 8, 2019
jamadden added a commit to NextThought/ultramysql that referenced this issue Jul 8, 2019
@jamadden jamadden modified the milestones: 3.0, 3.0a4 Jul 8, 2019
jamadden added a commit that referenced this issue Jul 8, 2019
Remove the umysqldb driver. Fixes #264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant