Fixed url paths not covered in api coverage report #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pected url when the path had multiple path parameters due to regex pattern matching error during parsing
joelrosario
requested changes
Jul 22, 2023
| @@ -6,7 +6,7 @@ import `in`.specmatic.core.Result | |||
|
|
|||
| class ScenarioTestGenerationFailure(val scenario: Scenario, val e: Throwable) : ContractTest { | |||
| override fun testResultRecord(result: Result): TestResultRecord { | |||
| return TestResultRecord(scenario.path.replace(Regex("""\((.*):.*\)"""), "{$1}"), scenario.method, scenario.httpResponsePattern.status, result.testResult()) | |||
| return TestResultRecord(scenario.path.replace(Regex("""\((.*?):.*?\)"""), "{$1}"), scenario.method, scenario.httpResponsePattern.status, result.testResult()) | |||
There was a problem hiding this comment.
Can you add a unit test for this method
| @@ -6,7 +6,7 @@ import `in`.specmatic.core.executeTest | |||
|
|
|||
| class ScenarioTest(val scenario: Scenario, private val generativeTestingEnabled: Boolean = false) : ContractTest { | |||
| override fun testResultRecord(result: Result): TestResultRecord { | |||
| return TestResultRecord(scenario.path.replace(Regex("""\((.*):.*\)"""), "{$1}"), scenario.method, scenario.status, result.testResult()) | |||
| return TestResultRecord(scenario.path.replace(Regex("""\((.*?):.*?\)"""), "{$1}"), scenario.method, scenario.status, result.testResult()) | |||
There was a problem hiding this comment.
Can you add a unit test for this method
| @@ -110,7 +110,7 @@ class TestReport(private val testReportRecords: MutableList<TestResultRecord> = | |||
| logger.newLine() | |||
|
|
|||
| val recordsWithFixedURLs = testReportRecords.map { | |||
| it.copy(path = it.path.replace(Regex("""\((.*):.*\)"""), "{$1}")) | |||
| it.copy(path = it.path.replace(Regex("""\((.*?):.*?\)"""), "{$1}")) | |||
There was a problem hiding this comment.
Can you extract this functionality to a method and add a unit test.
The functionality of doing the regex replace across all 3 seems the same.. if so, can you extract the regex replace itself into a common method.
…on brackets to braces to its own function
joelrosario
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Url path with multiple path parameters is not parsed correctly due to regex pattern matching error during parsing (requires non-greedy matching)
Why: Api Coverage is incorrect due to wrong path string manipulation. All apis with multiple path params are marked as not covered
How: Simple modification of the regex used for path conversion to be non greedy using
?operatorChecklist:
Issue ID:
N/A