Add Sound.setActive and Sound.setMode for iOS AVAudioSession support #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent. Thanks! |
|
Thanks for merging, @zmxv. Would you mind cutting a release? |
aidan-doherty
pushed a commit
to aidan-doherty/react-native-sound
that referenced
this pull request
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVAudioSessionhas a mode parameter that is designed to work in tandem with a category to determine the OS-level mixing behavior across multiple app's sessions.This PR adds support for setting the mode parameter in a manner similar to category. It includes type annotations and documentation.
This PR also adds support for invoking
setActiveon theAVAudioSession, which is something that has been lost in the deprecation of theenableandenableInSilenceModemethods.setActiveis an important mechanism for signalling the interruptibility of the current app. I considered just callingsetActive: YESwithinsetCategory, but in light of the addition ofsetMode, it makes more sense to have this as an independent method.These aren't useful for 95% of apps (the simple use cases), but if you want to build an iOS app that is resilient to phone calls and other interruptions, these are important.