Android: Catch IllegalStateException on local file playback #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiancook
reviewed
Jun 16, 2017
| try { | ||
| player.prepareAsync(); | ||
| } catch (IllegalStateException ignored) { | ||
| // When loading files from a file, we useMediaPlayer.create, which actually |
There was a problem hiding this comment.
Would this not mean we never invoke our callback? Can we detect the state?
There was a problem hiding this comment.
AFAIK that exception is only thrown if the preparation has already been done. Actual errors should still happen.
There was a problem hiding this comment.
Yes, but callback would never be invoked, which means react native is never informed. Unless onPrepared is invoked each time?
There was a problem hiding this comment.
... and detecting the state isn't possible. There's no 'isPrepared' or 'getState' on MediaPlayer :-(
There was a problem hiding this comment.
If onPrepared isn't invoked, we could split the creation to a file based media player, and an http/s based one
aidan-doherty
pushed a commit
to aidan-doherty/react-native-sound
that referenced
this pull request
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of building a much better test harness in
react-native-sound-demoI found that local file playback was broken in Android. This fixes it.