Remove player.prepare() of prepare() in android native module #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdurrahmanekr
approved these changes
Apr 28, 2017
|
+1 |
|
I tested with MIUI and it works. |
|
tks, the same problem caused |
|
These changes have been added to #169, so if that one gets merged we can close this PR. |
|
Thanks for this - these changes have been merged in via #169 (that included your changes) so I'm closing. |
|
Hi, this change actually broke the new URL support for Android, so I can no longer load sounds from the network. I'll send a PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
android.media.MediaPlayer.prepare()is not necessary because create() method call it automatically.Also, player.prepare() code in
RNSoundModule.javathrows an exception with{ code: -1, message: null }with my device (Galaxy S7 edge, Android 7.0) and avd (Android 6.0 Google APIs, x86).Since I removed
player.prepare(), the error has gone.