-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: input processor behavior invocation #2714
Feature: input processor behavior invocation #2714
Conversation
Allow input processors to return a special value if a given input event should not be further processed/propagated.
I'm immediately curious about the complex behavior/hold-tap limitations. Could you elaborate a bit? |
Those behaviors rely on tracking things based on the key position, which isn't part of the binding event details when there's no associated key position for this. This PR is still a draft because I'm next working on a "event to key position event mapper" processor that will allow certain input events to generate key position events, i.e. "key presses", to trigger keymap processing like normal, for folks interested in extending they keymaps to allow more complex behaviors. |
I recall a brief discussion on Discord a while ago where I suggested a (pair of) behavior to trigger behaviors from specific locations in the keymap, "Trigger the behavior found at my current index on this layer", "trigger the behavior found on layer X at index X". Though another processor is probably a cleaner way of resolving the issue, but as a backup/if you like the idea. |
I want the processor to honor whatever layers are active though, so folks can combine the processor with various layer settings for effect. |
90b2d71
to
ecd720c
Compare
@Nick-Munnich Ok, I went with extending the virtual key positions to support this more extensively, and remove that limitation. I've removed that note, and added a test showing the use with hold tap. |
947a15c
to
64c4ba5
Compare
04c4c7b
to
43539c4
Compare
6455e4f
to
abd69da
Compare
76050dd
to
221524c
Compare
Add the ability to intercept certain input events and trigger behaviors when they occur. Co-authored-by: Jorge Villalobos <minusfive@users.noreply.github.com> Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
221524c
to
c3c9c56
Compare
Adds a new input processor that can trigger behaviors for certain input events.
PR check-list