feat(shields): Add Levinson support #1648
Conversation
There was a problem hiding this comment.
After rebasing on main, you'll definitely need to install and run pre-commit here to deal with formatting issues (tabs, trailing whitespace, etc).
| @@ -0,0 +1 @@ | |||
| CONFIG_ZMK_SLEEP=y | |||
There was a problem hiding this comment.
| CONFIG_ZMK_SLEEP=y | |
| #CONFIG_ZMK_SLEEP=y |
Leaving this uncommented may flout the
.conffile has optional extra features commented out
guideline from the PR checklist.
Someone with merge privileges can make a final ruling on that.
| zmk,kscan = &kscan0; | ||
| zmk,matrix_transform = &default_transform; | ||
| }; | ||
|
|
There was a problem hiding this comment.
| kscan0: kscan { | |
| compatible = "zmk,kscan-gpio-matrix"; | |
| diode-direction = "col2row"; | |
| }; | |
You may not be able to put col-gpios or row-gpios in here, but these attributes are common so they don't need to be duplicated. (label is deprecated, and has been removed.)
| / { | ||
| kscan0: kscan { | ||
| compatible = "zmk,kscan-gpio-matrix"; | ||
| label = "KSCAN"; | ||
| diode-direction = "col2row"; |
There was a problem hiding this comment.
| / { | |
| kscan0: kscan { | |
| compatible = "zmk,kscan-gpio-matrix"; | |
| label = "KSCAN"; | |
| diode-direction = "col2row"; | |
| &kscan0 { |
You're going to need to reformat this file to get rid of the extra indentation, but you'll need to run pre-commit after the rebase to clear up formatting issues anyway.
| , <&pro_micro 8 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)> | ||
| , <&pro_micro 9 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)> | ||
| ; | ||
| }; |
| / { | ||
| kscan0: kscan { | ||
| compatible = "zmk,kscan-gpio-matrix"; | ||
| label = "KSCAN"; | ||
| diode-direction = "col2row"; |
There was a problem hiding this comment.
| / { | |
| kscan0: kscan { | |
| compatible = "zmk,kscan-gpio-matrix"; | |
| label = "KSCAN"; | |
| diode-direction = "col2row"; | |
| &kscan0 { |
| , <&pro_micro 14 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)> | ||
| , <&pro_micro 15 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)> | ||
| ; | ||
| }; |
| # Copyright (c) 2023 The ZMK Contributors | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
|
|
| config ZMK_KEYBOARD_NAME | ||
| default "Levinson" | ||
|
|
||
| config ZMK_SPLIT_BLE_ROLE_CENTRAL |
There was a problem hiding this comment.
| config ZMK_SPLIT_BLE_ROLE_CENTRAL | |
| config ZMK_SPLIT_ROLE_CENTRAL |
ghost
closed this by deleting the head repository
Reviving the work @blistergeist did on this PR to enable Levinson support.
Board/Shield Check-list
.zmk.ymlmetadata file added&pro_microused in favor of&pro_micro_d/aif applicable.conffile has optional extra features commented out