Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(board): Add Adafruit Feather NRF52840 board #1465

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tmbutcher
Copy link

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

Since #1065 seems to have stalled out, I thought I'd create a new PR to add support for this board. I've been using these files for more than a year now with no problem. This is my first PR, though, so apologies if I'm missing anything that's supposed to be in here.

@tmbutcher tmbutcher changed the title Adding Adafruit Feather NRF52840 board feat(board): add Add Adafruit Feather NRF52840 board Oct 19, 2022
@tmbutcher tmbutcher changed the title feat(board): add Add Adafruit Feather NRF52840 board feat(board): Add Adafruit Feather NRF52840 board Oct 19, 2022
@petejohanson
Copy link
Contributor

Did you see #1065 (comment) where I suggested a better approach to avoid duplicating the existing Zephyr board definition?

@tmbutcher
Copy link
Author

Ah, yes, I think I saw that, but I probably misunderstood and thought that it related to the issue of splitting the board and shield into different PRs.

In theory, I'm happy to revise this PR as necessary, but in reality I worry that the better approach that you want exceeds my understanding of what should be in the conf and overlay files vs. what doesn't need to be there. I've taken a look at the conf and overlay files that are currently in the boards directory, but that left me with a bunch of questions. I suspect that the issue I'm running into here is that my knowledge of core make files is lacking. I'll take a look at those and see if I can iron out my questions.

AdrianBorg added a commit to AdrianBorg/zmk-config that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants