New Sheild Pteron36 #1364

harshitgoel96 · 2022-06-26T10:01:27Z

Board/Shield Check-list

…pteron36

…on36

Nicell · 2022-06-26T19:09:14Z

Hi @harshitgoel96! I see you didn't check the last part of the checklist. Do you plan to run a group buy or have this shield stocked in stores? If not, we would recommend putting this definition in a zmk-config repo.

caksoylar · 2022-07-04T01:06:07Z

app/boards/shields/pteron36/Kconfig.defconfig

+config ZMK_KEYBOARD_NAME
+    default "Pteron36"
+
+config ZMK_SPLIT_BLE_ROLE_CENTRAL


Suggested change

config ZMK_SPLIT_BLE_ROLE_CENTRAL

config ZMK_SPLIT_ROLE_CENTRAL

caksoylar · 2022-07-04T01:06:09Z

app/boards/shields/pteron36/pteron36.conf

+# Copyright (c) 2022 The ZMK Contributors
+# SPDX-License-Identifier: MIT
+
+# Uncomment the following line to enable the Lotus58 OLED Display


Might want to remove the display and encoder configs to not confuse users, if they aren't supported by the firmware yet.

caksoylar · 2022-07-04T01:06:36Z

app/boards/shields/pteron36/pteron36.dtsi

@@ -0,0 +1,45 @@
+/*
+ * Copyright (c) 2020 Pete Johanson


caksoylar · 2022-07-04T01:09:32Z

app/boards/shields/pteron36/pteron36.keymap

+		compatible = "zmk,keymap";
+
+		default_layer {
+// ------------------------------------------------------------------------------------------------------------


I'd either correct the commented layer diagrams or remove them altogether.

caksoylar · 2022-07-04T01:12:00Z

app/boards/shields/pteron36/pteron36.keymap

+// |   F1  |  F2 |  F3 |  F4  |  F5  |  F6  |                   |      |   <-  |   ^   |  v   |  ->   |       |
+// |   F7  |  F8 |  F9 |  F10 |  F11 |  F12 |        |  |       |  +   |   -   |   =   |  [   |   ]   |   \   |
+//                     |      |      |      |        |  |       |      |       |       |
+			bindings = <


Isn't this identical to the MOUR layer?

harshitgoel96 · 2022-07-12T11:06:08Z

Hi @harshitgoel96! I see you didn't check the last part of the checklist. Do you plan to run a group buy or have this shield stocked in stores? If not, we would recommend putting this definition in a zmk-config repo.

@Nicell the keyboard does not have a group buy or official sales channel, its an opensourced project with pcb fabrication files available here
i will look into zmk-config repo

harshitgoel96 · 2022-07-12T11:11:20Z

@Nicell I did not find any separate zmk-config repo, is the process documented somewhere?

caksoylar · 2022-07-12T20:21:00Z

@harshitgoel96 ZMK config repos refer to repos typically created via the user setup script for end users to use. As noted in the new shield documentation, custom shields can also live in this sort of config repos and the build system will pick up the shield definition when building.

Below are a few examples:

lesshonor

I'm going to make suggestions in good faith, but you already know this PR will not be merged and should close it out.

lesshonor · 2023-11-23T01:23:41Z

app/boards/shields/pteron36/pteron36.dtsi

+RC(0,0) RC(0,1) RC(0,2) RC(0,3) RC(0,4)                 RC(0,5)RC(0,6) RC(0,7) RC(0,8) RC(0,9)
+RC(1,0) RC(1,1) RC(1,2) RC(1,3) RC(1,4)                 RC(1,5) RC(1,6) RC(1,7) RC(1,8) RC(1,9)
+RC(2,0) RC(2,1) RC(2,2) RC(2,3) RC(2,4)                 RC(2,5) RC(2,6) RC(2,7) RC(2,8) RC(2,9)
+				RC(3,0) RC(3,1) RC(3,2)                 RC(3,7) RC(3,8) RC(3,9) 


Suggested change

RC(0,0) RC(0,1) RC(0,2) RC(0,3) RC(0,4) RC(0,5)RC(0,6) RC(0,7) RC(0,8) RC(0,9)

RC(1,0) RC(1,1) RC(1,2) RC(1,3) RC(1,4) RC(1,5) RC(1,6) RC(1,7) RC(1,8) RC(1,9)

RC(2,0) RC(2,1) RC(2,2) RC(2,3) RC(2,4) RC(2,5) RC(2,6) RC(2,7) RC(2,8) RC(2,9)

RC(3,0) RC(3,1) RC(3,2) RC(3,7) RC(3,8) RC(3,9)

RC(0,0) RC(0,1) RC(0,2) RC(0,3) RC(0,4) RC(0,9) RC(0,8) RC(0,7) RC(0,6) RC(0,5)

RC(1,0) RC(1,1) RC(1,2) RC(1,3) RC(1,4) RC(1,9) RC(1,8) RC(1,7) RC(1,6) RC(1,5)

RC(2,0) RC(2,1) RC(2,2) RC(2,3) RC(2,4) RC(2,9) RC(2,8) RC(2,7) RC(2,6) RC(2,5)

RC(3,0) RC(3,1) RC(3,2) RC(3,7) RC(3,6) RC(3,5)

If you reorder the transform, you can use the same col-gpios for both sides.

lesshonor · 2023-11-23T01:24:09Z

app/boards/shields/pteron36/pteron36.dtsi

+		label = "KSCAN";
+


Suggested change

label = "KSCAN";

The label attribute has been deprecated here.

lesshonor · 2023-11-23T01:26:19Z

app/boards/shields/pteron36/pteron36.dtsi

+			, <&pro_micro  8 (GPIO_ACTIVE_HIGH )>
+			, <&pro_micro  9 (GPIO_ACTIVE_HIGH )>
+			;
+


Suggested change

col-gpios

= <&pro_micro 19 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 18 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 15 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 14 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 16 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

;

lesshonor · 2023-11-23T01:30:58Z

app/boards/shields/pteron36/pteron36.dtsi

+			, <&pro_micro  6 (GPIO_ACTIVE_HIGH )>
+			, <&pro_micro  8 (GPIO_ACTIVE_HIGH )>
+			, <&pro_micro  9 (GPIO_ACTIVE_HIGH )>


ZMK's standard is to use spaces for indentation instead of tabs. Installing and running pre-commit will correct formatting issues.

Suggested change

, <&pro_micro 6 (GPIO_ACTIVE_HIGH )>

, <&pro_micro 8 (GPIO_ACTIVE_HIGH )>

, <&pro_micro 9 (GPIO_ACTIVE_HIGH )>

, <&pro_micro 6 (GPIO_ACTIVE_HIGH)>

, <&pro_micro 8 (GPIO_ACTIVE_HIGH)>

, <&pro_micro 9 (GPIO_ACTIVE_HIGH)>

lesshonor · 2023-11-23T01:33:34Z

app/boards/shields/pteron36/pteron36_left.overlay

+
+&kscan0 {
+	col-gpios
+		= <&pro_micro  19 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>
+		, <&pro_micro  18 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>
+		, <&pro_micro  15 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>
+		, <&pro_micro  14 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>
+		, <&pro_micro  16 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>
+		;


Suggested change

&kscan0 {

col-gpios

= <&pro_micro 19 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 18 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 15 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 14 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 16 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

;

Moved to app/boards/shields/pteron36/pteron36.dtsi.

lesshonor · 2023-11-23T01:33:46Z

app/boards/shields/pteron36/pteron36_right.overlay

+
+&kscan0 {
+	col-gpios
+		= <&pro_micro  16 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>
+		, <&pro_micro  14 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>
+		, <&pro_micro  15 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>
+		, <&pro_micro  18 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>
+		, <&pro_micro  19 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>
+		;


Suggested change

&kscan0 {

col-gpios

= <&pro_micro 16 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 14 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 15 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 18 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

, <&pro_micro 19 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>

;

Moved to app/boards/shields/pteron36/pteron36.dtsi.

harshitgoel96 added 19 commits May 22, 2021 23:26

add pteron to list of shield

4edb09e

finizlise pteron config

8d94cf0

fixed keymap filef'

7efbd5d

change col direction

3064bfa

Merge branch 'pteron36' of https://github.com/harshitgoel96/zmk into …

40b483d

…pteron36

fix pull down setting for row and cols

5c34846

Merge branch 'pteron36' of https://github.com/harshitgoel96/zmk into …

865efce

…pteron36

fix firmware

61e1cec

update keymap transform for left

4e1e2ba

pteron36 update

22fc96a

Merge branch 'main' into pteron36

59fe749

cleanup

7085eb8

cleanup

e4ad7ab

cleanup

e4f210a

node correction

966934f

update adv name, restore conf file

f4ccb76

keycode update

23b2cd0

Merge branch 'main' of https://github.com/harshitgoel96/zmk into pter…

f7ad5e2

…on36

align pin config for PR

a27c986

Nicell added the shields PRs and issues related to shields label Jun 26, 2022

caksoylar reviewed Jul 4, 2022

View reviewed changes

fix pin config

fda1828

lesshonor suggested changes Nov 23, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Sheild Pteron36 #1364

New Sheild Pteron36 #1364

harshitgoel96 commented Jun 26, 2022 •

edited

Loading

Nicell commented Jun 26, 2022

caksoylar Jul 4, 2022

caksoylar Jul 4, 2022

caksoylar Jul 4, 2022

caksoylar Jul 4, 2022

caksoylar Jul 4, 2022

harshitgoel96 commented Jul 12, 2022

harshitgoel96 commented Jul 12, 2022

caksoylar commented Jul 12, 2022

lesshonor left a comment •

edited

Loading

lesshonor Nov 23, 2023

lesshonor Nov 23, 2023

lesshonor Nov 23, 2023

lesshonor Nov 23, 2023 •

edited

Loading

lesshonor Nov 23, 2023

lesshonor Nov 23, 2023

	config ZMK_SPLIT_BLE_ROLE_CENTRAL
	config ZMK_SPLIT_ROLE_CENTRAL

New Sheild Pteron36 #1364

Are you sure you want to change the base?

New Sheild Pteron36 #1364

Conversation

harshitgoel96 commented Jun 26, 2022 • edited Loading

Board/Shield Check-list

Nicell commented Jun 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harshitgoel96 commented Jul 12, 2022

harshitgoel96 commented Jul 12, 2022

caksoylar commented Jul 12, 2022

lesshonor left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lesshonor Nov 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harshitgoel96 commented Jun 26, 2022 •

edited

Loading

lesshonor left a comment •

edited

Loading

lesshonor Nov 23, 2023 •

edited

Loading