Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Kitsune Keyboards - Shapeshifter4060 board #1123

Closed
wants to merge 11 commits into from

Conversation

vosechu
Copy link

@vosechu vosechu commented Feb 6, 2022

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@Nicell Nicell added the shields PRs and issues related to shields label Jun 26, 2022
@vosechu vosechu force-pushed the add-shapeshifter4060-board branch from fbf7b4b to 8c957ae Compare October 16, 2022 21:52
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your website appears to be blank. You haven't finished filling out the PR template, but for inclusion into the zmkfirmware/zmk repo the following criterion needs to be met:

- [ ] Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

At the moment, this appears to be an OSH project that is not being sold now and has not been produced at scale previously. If that is the case, you should close this PR and create a zmk-config repo that places the shield under its config/ folder; i.e. config/boards/shields/shapeshifter4060.

# SPDX-License-Identifier: MIT

config SHIELD_SHAPESHIFTER4060
def_bool $(shields_list_contains,shapshifter4060)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def_bool $(shields_list_contains,shapshifter4060)
def_bool $(shields_list_contains,shapeshifter4060)

Going to make an assumption here.

// | SHIFT | A | S | D | F | G |-------|-------| H | J | K | L | ; | ' |
// | CTRL | Z | X | C | V | B |-------|-------| N | M | , | . | / | ENTER |
// |-------|ADJUST| LCTL | LALT | LGUI | LOWR | SPACE | SPACE | RAIS | LARW | DARW | UARW | RARW |-------|
bindings = <
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bindings = <
bindings = <

Formatting issue flagged by pre-commit, after rebasing on main.


kscan0: kscan_0 {
compatible = "zmk,kscan-gpio-matrix";
label = "KSCAN";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label = "KSCAN";

The label attribute has been deprecated.

@vosechu
Copy link
Author

vosechu commented Nov 21, 2023

You are 100% correct @lesshonor. It was close to production at scale, but I burned out on the project tbh. I’ll close for now.

@vosechu vosechu closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants