-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Kitsune Keyboards - Shapeshifter4060 board #1123
Conversation
fbf7b4b
to
8c957ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your website appears to be blank. You haven't finished filling out the PR template, but for inclusion into the zmkfirmware/zmk
repo the following criterion needs to be met:
zmk/.github/pull_request_template.md
Line 15 in d7d9eed
- [ ] Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead) |
At the moment, this appears to be an OSH project that is not being sold now and has not been produced at scale previously. If that is the case, you should close this PR and create a zmk-config
repo that places the shield under its config/
folder; i.e. config/boards/shields/shapeshifter4060
.
# SPDX-License-Identifier: MIT | ||
|
||
config SHIELD_SHAPESHIFTER4060 | ||
def_bool $(shields_list_contains,shapshifter4060) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def_bool $(shields_list_contains,shapshifter4060) | |
def_bool $(shields_list_contains,shapeshifter4060) |
Going to make an assumption here.
// | SHIFT | A | S | D | F | G |-------|-------| H | J | K | L | ; | ' | | ||
// | CTRL | Z | X | C | V | B |-------|-------| N | M | , | . | / | ENTER | | ||
// |-------|ADJUST| LCTL | LALT | LGUI | LOWR | SPACE | SPACE | RAIS | LARW | DARW | UARW | RARW |-------| | ||
bindings = < |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bindings = < | |
bindings = < |
Formatting issue flagged by pre-commit
, after rebasing on main
.
|
||
kscan0: kscan_0 { | ||
compatible = "zmk,kscan-gpio-matrix"; | ||
label = "KSCAN"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label = "KSCAN"; |
The label
attribute has been deprecated.
You are 100% correct @lesshonor. It was close to production at scale, but I burned out on the project tbh. I’ll close for now. |
Board/Shield Check-list
.zmk.yml
metadata file added&pro_micro
used in favor of&pro_micro_d/a
if applicable.conf
file has optional extra features commented out