feat(boards): Add 1up sweet 16 macropad #1102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicell
added
enhancement
lesshonor
suggested changes
Nov 14, 2023
Comment on lines
+38
to
+40
| &none &none &none &none | ||
| &none &none &none &none | ||
| &none &none &trans &bt BT_CLR |
There was a problem hiding this comment.
Suggested change
| &none &none &none &none | |
| &none &none &none &none | |
| &none &none &trans &bt BT_CLR | |
| &none &none &none &none | |
| &none &none &none &none | |
| &none &none &trans &bt BT_CLR |
Formatting issues uncovered by pre-commit.
Comment on lines
+1
to
+7
| &spi1 { | ||
| compatible = "nordic,nrf-spim"; | ||
| status = "okay"; | ||
| mosi-pin = <45>; | ||
| // Unused pins, needed for SPI definition, but not used by the ws2812 driver itself. | ||
| sck-pin = <5>; | ||
| miso-pin = <7>; |
There was a problem hiding this comment.
Migration to the pinctrl subsystem as part of the Zephyr 3.2 upgrade, and the &spi3 bus per #1746. (I'm sure you're familiar with rebasing et al...)
Suggested change
| &spi1 { | |
| compatible = "nordic,nrf-spim"; | |
| status = "okay"; | |
| mosi-pin = <45>; | |
| // Unused pins, needed for SPI definition, but not used by the ws2812 driver itself. | |
| sck-pin = <5>; | |
| miso-pin = <7>; | |
| &pinctrl { | |
| spi3_default: spi3_default { | |
| group1 { | |
| psels = <NRF_PSEL(SPIM_MOSI, 1, 13)>; | |
| }; | |
| }; | |
| spi3_sleep: spi3_sleep { | |
| group1 { | |
| psels = <NRF_PSEL(SPIM_MOSI, 1, 13)>; | |
| low-power-enable; | |
| }; | |
| }; | |
| }; | |
| &spi3 { | |
| compatible = "nordic,nrf-spim"; | |
| status = "okay"; | |
| pinctrl-0 = <&spi3_default>; | |
| pinctrl-1 = <&spi3_sleep>; | |
| pinctrl-names = "default", "sleep"; |
|
|
||
| kscan0: kscan_0 { | ||
| compatible = "zmk,kscan-gpio-matrix"; | ||
| label = "KSCAN"; |
There was a problem hiding this comment.
Suggested change
| label = "KSCAN"; | |
| wakeup-source; |
label is marked as deprecated for kscan nodes. wakeup-source is now required in order to allow keypresses to wake the keyboard from deep sleep.
lesshonor
suggested changes
Nov 15, 2023
There was a problem hiding this comment.
Forgot this:
- Please rename this file to
nice_nano_v2.overlay, for consistency. - After making the
pinctrland&spi3changes, make a copy of it in the same folder namednice_nano.overlayso just in case someone builds one of these with a v1 nice!nano, it will behave the same way.
lesshonor
suggested changes
Jul 7, 2024
Comment on lines
+7
to
+8
| #include <dt-bindings/zmk/matrix_transform.h> | ||
|
|
There was a problem hiding this comment.
Suggested change
| #include <dt-bindings/zmk/matrix_transform.h> |
This isn't actually being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 1up sweet 16. Still needs to be tested on real hardware.
Board/Shield Check-list
.zmk.ymlmetadata file added&pro_microused in favor of&pro_micro_d/aif applicable.conffile has optional extra features commented out