Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Peach keyboard #1081

Closed
wants to merge 3 commits into from
Closed

Add Peach keyboard #1081

wants to merge 3 commits into from

Conversation

kien242
Copy link

@kien242 kien242 commented Jan 1, 2022

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@Nicell
Copy link
Member

Nicell commented Jan 30, 2022

Hi @kien242. I see you haven't checked the Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase checkbox. We recommend for OSH or personal projects to use a zmk-config repo to house your shield/board configurations! 😄

@kien242
Copy link
Author

kien242 commented Feb 7, 2022

Yes sir. I will close this pr.

@kien242 kien242 closed this Feb 7, 2022
@kien242 kien242 deleted the dev_branch branch February 7, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants