-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Shield] Soyuz #1073
base: main
Are you sure you want to change the base?
[New Shield] Soyuz #1073
Conversation
Hi @vnzongzna, could you please add the shield checklist back to your PR description and check them as applicable? https://github.com/zmkfirmware/zmk/blob/main/.github/pull_request_template.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After rebasing
on main
, you'll definitely need to install and run pre-commit
to deal with formatting issues (tabs, trailing whitespace, etc).
name: soyuz by ai03 | ||
type: shield | ||
url: https://github.com/ai03-2725/Soyuz | ||
requires: [nice_nano] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requires: [nice_nano] | |
requires: [pro_micro] |
label = "KSCAN"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label = "KSCAN"; |
This label has been deprecated.
@@ -0,0 +1,25 @@ | |||
#include <behaviors.dtsi> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include <behaviors.dtsi> | |
/* | |
* Copyright (c) 2020 The ZMK Contributors | |
* | |
* SPDX-License-Identifier: MIT | |
*/ | |
#include <behaviors.dtsi> |
Missing copyright. I'm not going to update the date as I am not making a substantial change from the original file, though someone with merge permissions may request it be updated.
@@ -0,0 +1,8 @@ | |||
file_format: "1" | |||
id: soyuz | |||
name: soyuz by ai03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: soyuz by ai03 | |
name: Soyuz |
The URL provides us with a pretty good idea of who this design was created by.
No description provided.