Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Shield] Soyuz #1073

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[New Shield] Soyuz #1073

wants to merge 1 commit into from

Conversation

vnzongzna
Copy link

No description provided.

@Nicell
Copy link
Member

Nicell commented Jan 30, 2022

Hi @vnzongzna, could you please add the shield checklist back to your PR description and check them as applicable? https://github.com/zmkfirmware/zmk/blob/main/.github/pull_request_template.md

@Nicell Nicell added enhancement New feature or request shields PRs and issues related to shields labels Jan 30, 2022
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing on main, you'll definitely need to install and run pre-commit to deal with formatting issues (tabs, trailing whitespace, etc).

name: soyuz by ai03
type: shield
url: https://github.com/ai03-2725/Soyuz
requires: [nice_nano]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
requires: [nice_nano]
requires: [pro_micro]

Comment on lines +17 to +18
label = "KSCAN";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label = "KSCAN";

This label has been deprecated.

@@ -0,0 +1,25 @@
#include <behaviors.dtsi>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <behaviors.dtsi>
/*
* Copyright (c) 2020 The ZMK Contributors
*
* SPDX-License-Identifier: MIT
*/
#include <behaviors.dtsi>

Missing copyright. I'm not going to update the date as I am not making a substantial change from the original file, though someone with merge permissions may request it be updated.

@@ -0,0 +1,8 @@
file_format: "1"
id: soyuz
name: soyuz by ai03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: soyuz by ai03
name: Soyuz

The URL provides us with a pretty good idea of who this design was created by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants