refactor(behaviors): Final global-quick-tap deprecation.

zmkfirmware · Sep 27, 2023 · 48c9a8a · 48c9a8a
1 parent b87d237
commit 48c9a8a
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 9 deletions.
diff --git a/app/boards/shields/cradio/cradio.keymap b/app/boards/shields/cradio/cradio.keymap
@@ -18,7 +18,7 @@
             flavor = "tap-preferred";
             tapping-term-ms = <220>;
             quick-tap-ms = <150>;
-            global-quick-tap;
+            require-prior-idle-ms = <100>;
             bindings = <&kp>, <&kp>;
         };
     };

diff --git a/app/dts/bindings/behaviors/zmk,behavior-hold-tap.yaml b/app/dts/bindings/behaviors/zmk,behavior-hold-tap.yaml
@@ -13,15 +13,18 @@ properties:
     required: true
   tapping-term-ms:
     type: int
-  tapping_term_ms: # deprecated
+  tapping_term_ms:
     type: int
+    deprecated: true
   quick-tap-ms:
     type: int
     default: -1
-  quick_tap_ms: # deprecated
+  quick_tap_ms:
     type: int
-  global-quick-tap: # deprecated
+    deprecated: true
+  global-quick-tap:
     type: boolean
+    deprecated: true
   require-prior-idle-ms:
     type: int
     default: -1

diff --git a/app/tests/hold-tap/balanced/8-require-prior-idle/1-basic/native_posix_64.keymap b/app/tests/hold-tap/balanced/8-require-prior-idle/1-basic/native_posix_64.keymap
@@ -16,7 +16,7 @@
         ZMK_MOCK_PRESS(1,0,10)
         ZMK_MOCK_RELEASE(1,0,10)
         ZMK_MOCK_RELEASE(0,0,400)
-        /* global quick tap */
+        /* require-prior-idle */
         ZMK_MOCK_PRESS(1,0,10)
         ZMK_MOCK_PRESS(0,0,400)
         ZMK_MOCK_RELEASE(1,0,10)

diff --git a/app/tests/hold-tap/hold-preferred/8-require-prior-idle/1-basic/native_posix_64.keymap b/app/tests/hold-tap/hold-preferred/8-require-prior-idle/1-basic/native_posix_64.keymap
@@ -16,7 +16,7 @@
         ZMK_MOCK_PRESS(1,0,10)
         ZMK_MOCK_RELEASE(1,0,10)
         ZMK_MOCK_RELEASE(0,0,400)
-        /* global quick tap */
+        /* require-prior-idle */
         ZMK_MOCK_PRESS(1,0,10)
         ZMK_MOCK_PRESS(0,0,400)
         ZMK_MOCK_RELEASE(1,0,10)

diff --git a/app/tests/hold-tap/tap-preferred/8-require-prior-idle/1-basic/native_posix_64.keymap b/app/tests/hold-tap/tap-preferred/8-require-prior-idle/1-basic/native_posix_64.keymap
@@ -16,7 +16,7 @@
         ZMK_MOCK_PRESS(1,0,10)
         ZMK_MOCK_RELEASE(1,0,10)
         ZMK_MOCK_RELEASE(0,0,400)
-        /* global quick tap */
+        /* require-prior-idle */
         ZMK_MOCK_PRESS(1,0,10)
         ZMK_MOCK_PRESS(0,0,400)
         ZMK_MOCK_RELEASE(1,0,10)

diff --git a/...tests/hold-tap/tap-unless-interrupted/6-require-prior-idle/1-basic/native_posix_64.keymap b/...tests/hold-tap/tap-unless-interrupted/6-require-prior-idle/1-basic/native_posix_64.keymap
@@ -16,7 +16,7 @@
         ZMK_MOCK_PRESS(1,0,10)
         ZMK_MOCK_RELEASE(1,0,10)
         ZMK_MOCK_RELEASE(0,0,400)
-        /* global quick tap */
+        /* require-prior-idle */
         ZMK_MOCK_PRESS(1,0,10)
         ZMK_MOCK_PRESS(0,0,400)
         ZMK_MOCK_RELEASE(1,0,10)

diff --git a/docs/docs/behaviors/hold-tap.md b/docs/docs/behaviors/hold-tap.md
@@ -58,7 +58,7 @@ For example, the following hold-tap configuration enables `require-prior-idle-ms
 ```
 rpi: require_prior_idle {
     compatible = "zmk,behavior-hold-tap";
-    label = "GLOBAL_QUICK_TAP";
+    label = "REQUIRE_PRIOR_IDLE";
     #binding-cells = <2>;
     flavor = "tap-preferred";
     tapping-term-ms = <200>;