Simplify replace placeholder #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cover filter/filterNot
correcting the indentation of yield expression
fixing the test for the last flatMap
tgodzik
commented
Jun 7, 2022
| // case class YieldExpression(expression: EnumerationValue) | ||
| private def replacePlaceHolder(tree: Term, newName: Term.Name): Term = | ||
| tree match { | ||
| case Term.Apply(fun, args) => |
There was a problem hiding this comment.
We should only probably allow this once, so that we don't go to any further applies.
zmerr
force-pushed
the
flatMap-forComprehension-switch
branch
from
65b290b
to
12e9c7c
Compare
zmerr
force-pushed
the
flatMap-forComprehension-switch
branch
2 times, most recently
from
6dc2b8b
to
1792264
Compare
tgodzik
force-pushed
the
flatMap-forComprehension-switch
branch
2 times, most recently
from
055b64a
to
316c5bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.