Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make revoke_token() accessible #402

Merged
merged 5 commits into from
Nov 6, 2021

Conversation

thorstenfleischmann
Copy link
Contributor

New function revoke_token() and revoke_tokens()

Enables the usage of revoke_token() for use cases which needs token revocation without logout.

New function revoke_token() and revoke_tokens()
@bodewig
Copy link
Collaborator

bodewig commented Oct 28, 2021

Thank you @thorstenfleischmann could you please add documentation as well? Extra bonus for adding tests :-)

Also please add yourself to the AUTHORS file.

While looking through your change I realized the log statements will cause a Lua error if token_type_hint is nil - and it shares this "quality" with the existing openidc_revoke_token function, wich I'll fix now.

@thorstenfleischmann
Copy link
Contributor Author

Thanks @bodewig for your feedback!

could you please add documentation as well? Extra bonus for adding tests :-)

I added a new block to the readme and one (very basic) test. It took me quite some time to get into the design of the tests.

Also please add yourself to the AUTHORS file.

Done

While looking through your change I realized the log statements will cause a Lua error if token_type_hint is nil - and it shares this "quality" with the existing openidc_revoke_token function, wich I'll fix now.

I took care of that as well

@bodewig bodewig merged commit 50f237b into zmartzone:master Nov 6, 2021
bodewig added a commit that referenced this pull request Nov 6, 2021
@bodewig
Copy link
Collaborator

bodewig commented Nov 6, 2021

great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants