Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send back URI arguments to prevent XSS #306

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Do not send back URI arguments to prevent XSS #306

merged 2 commits into from
Feb 5, 2020

Conversation

barrelmaker97
Copy link
Contributor

Fix for #305, no longer sending back arguments provided in the URI or session details.

zandbelt
zandbelt reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@zandbelt zandbelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like the original message logged server side, and the non-sensitive summary to be displayed externally

@barrelmaker97
Copy link
Contributor Author

@zandbelt Fixed, external logs are clean and internal logs are still detailed.

@barrelmaker97 barrelmaker97 removed the request for review from bodewig February 4, 2020 19:27
@barrelmaker97
Copy link
Contributor Author

@zandbelt As a side note, is it possible to release a patch version with this change in it? Just wondering if you have a release schedule.

@bodewig bodewig merged commit d7f3175 into zmartzone:master Feb 5, 2020
bodewig added a commit that referenced this pull request Feb 5, 2020
@bodewig
record #306
9afee2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zandbelt zandbelt zandbelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barrelmaker97 @zandbelt @bodewig