Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OPM installation with newer lua-resty-http versions #279

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

GUI
Copy link
Contributor

@GUI GUI commented Aug 3, 2019

The pintsized/lua-resty-http git repo was renamed to ledgetech/lua-resty-http for the 0.13 release. The repo now also redirects from "pintsized" to "ledgetech" on github.com: https://github.com/pintsized/lua-resty-http

This switches the OPM dependency to the new repo name. Without this, you can't install lua-resty-openidc if you already have the newer pintsized/lua-resty-http OPM package installed, due to package conflicts:

$ opm get ledgetech/lua-resty-http
* Fetching ledgetech/lua-resty-http  
  Downloading https://opm.openresty.org/api/pkg/tarball/ledgetech/lua-resty-http-0.14.opm.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 20862  100 20862    0     0  32597      0 --:--:-- --:--:-- --:--:-- 32596
Package ledgetech/lua-resty-http 0.14 installed successfully under /usr/local/openresty/site/ .


$ opm get zmartzone/lua-resty-openidc
* Fetching zmartzone/lua-resty-openidc  
  Downloading https://opm.openresty.org/api/pkg/tarball/zmartzone/lua-resty-openidc-1.7.2.opm.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 30393  100 30393    0     0   126k      0 --:--:-- --:--:-- --:--:--  126k
ERROR: failed to install pintsized/lua-resty-http: ledgetech/lua-resty-http 0.14 already installed.

The "pintsized/lua-resty-http" git repo was renamed to
"ledgetech/lua-resty-http" for the 0.13 release:
ledgetech/lua-resty-http@f71e970#diff-a580a87ff9da14b51504d149be8ecaff
The repo now also redirects from "pintsized" to "ledgetech" on
github.com: https://github.com/pintsized/lua-resty-http

This switches the dependency to the new repo name. Without this, you
can't install lua-resty-openidc if you already have the newer
"pintsized/lua-resty-http" package installed, due to package conflicts.
@zandbelt zandbelt requested review from zandbelt and bodewig August 5, 2019 18:54
Copy link
Contributor

@zandbelt zandbelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's indeed more healthy

Copy link
Collaborator

@bodewig bodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, seems to be the right move.

luarocks only has 0.13 but not 0.14 which is a bit unfortunate. We probably should bump the dependency to >= 0.13 inside the rockspec as well.

@zandbelt zandbelt merged commit 26ce9cc into zmartzone:master Aug 8, 2019
@zandbelt
Copy link
Contributor

zandbelt commented Aug 8, 2019

luarocks only has 0.13 but not 0.14 which is a bit unfortunate. We probably should bump the dependency to >= 0.13 inside the rockspec as well.

I don't see why we'd need to depend on the latest if the reference is unchanged; it doesn't seem like the origin matters on luarocks/rockspec.

@bodewig
Copy link
Collaborator

bodewig commented Aug 8, 2019

I see. Right now the opm dependency list says we depend on a different version of lua-resty-http than the rockspec. But this probably isn't that important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants