added error handling when opening session. #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
session start fails if storage adapter host is not accessible (set $session_storage memcache/redis;) improved message in logs will be as following: 2019/04/23 08:00:06 [error] 21#21: *1 [lua] openidc.lua:1344: authenticate(): Error starting session: memcache.local could not be resolved (3: Host not found) instead of current unclear message: attempt to index local 'session' (a nil value)
|
looks pretty useful to me, @bodewig whaddayathink? |
|
yes, absolutely. @vershnik you may want to add yourself to the AUTHORS file. |
|
@bodewig I will do that in my next pull request |
bodewig
added a commit
that referenced
this pull request
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session start fails if storage adapter host is not accessible (set $session_storage memcache/redis;)
improved message in logs will be as following:
2019/04/23 08:00:06 [error] 21#21: *1 [lua] openidc.lua:1344: authenticate(): Error starting session: memcache.local could not be resolved (3: Host not found)
instead of current unclear message: attempt to index local 'session' (a nil value)