Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip nonce verification by configuration? #193

Closed
thewilli opened this issue Sep 10, 2018 · 1 comment · Fixed by #198
Closed

skip nonce verification by configuration? #193

thewilli opened this issue Sep 10, 2018 · 1 comment · Fixed by #198

Comments

@thewilli
Copy link

My OpenID Connect Provider for some reason ignores the nonce parameter, so the resulting id token won't contain it and the verification fails.

Of course I could simply disable the verification by commenting it out, but of course don't want to do this for production.

Is there any way to configure the module to just don't verify the nonce? At least it seems there should be a way because of the if nonce condition, so as far as I understand if no nonce was added to the session, it isn't checked.

@bodewig
Copy link
Collaborator

bodewig commented Sep 10, 2018

Then your OIDC Provider violates the spec and you should open a bug report

https://openid.net/specs/openid-connect-core-1_0.html#IDToken

If present in the Authentication Request, Authorization Servers MUST include a nonce Claim in the ID Token with the Claim Value being the nonce value sent in the Authentication Request.

That being said it seems the cleaner approach would be to not generate a nonce if the OP is known to be broken. I.e. skip the creation in openidc_authorize rather than skip the verification.

bodewig added a commit that referenced this issue Sep 15, 2018
needed to deal with broken OpenID Connect providers, closes #193

Signed-off-by: Stefan Bodewig <stefan.bodewig@innoq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants