fix #541

zloirock · May 7, 2019 · fe7c851 · fe7c851
1 parent 0af298b
commit fe7c851
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/packages/core-js/internals/object-assign.js b/packages/core-js/internals/object-assign.js
@@ -1,5 +1,6 @@
 'use strict';
 // 19.1.2.1 Object.assign(target, source, ...)
+var DESCRIPTORS = require('../internals/descriptors');
 var objectKeys = require('../internals/object-keys');
 var getOwnPropertySymbolsModule = require('../internals/object-get-own-property-symbols');
 var propertyIsEnumerableModule = require('../internals/object-property-is-enumerable');
@@ -29,6 +30,9 @@ module.exports = !nativeAssign || require('../internals/fails')(function () {
     var length = keys.length;
     var j = 0;
     var key;
-    while (length > j) if (propertyIsEnumerable.call(S, key = keys[j++])) T[key] = S[key];
+    while (length > j) {
+      key = keys[j++];
+      if (!DESCRIPTORS || propertyIsEnumerable.call(S, key)) T[key] = S[key];
+    }
   } return T;
 } : nativeAssign;
diff --git a/tests/pure/es.object.assign.js b/tests/pure/es.object.assign.js
@@ -16,6 +16,7 @@ QUnit.test('Object.assign', assert => {
   assert.strictEqual(typeof string, 'object');
   assert.strictEqual(String(string), 'qwe');
   assert.strictEqual(string.q, 1);
+  assert.same(assign({}, { valueOf: 42 }).valueOf, 42, 'IE enum keys bug');
   if (DESCRIPTORS) {
     object = { baz: 1 };
     assign(object, defineProperty({}, 'bar', {

diff --git a/tests/tests/es.object.assign.js b/tests/tests/es.object.assign.js
@@ -18,6 +18,7 @@ QUnit.test('Object.assign', assert => {
   assert.strictEqual(typeof string, 'object');
   assert.strictEqual(String(string), 'qwe');
   assert.strictEqual(string.q, 1);
+  assert.same(assign({}, { valueOf: 42 }).valueOf, 42, 'IE enum keys bug');
   if (DESCRIPTORS) {
     object = { baz: 1 };
     assign(object, defineProperty({}, 'bar', {