Skip to content

Commit

Permalink
add a link to issue
Browse files Browse the repository at this point in the history
  • Loading branch information
zloirock committed Feb 21, 2023
1 parent e61e4f0 commit 1fc7ae4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/unit-global/web.url.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ QUnit.test('URL constructor', assert => {
assert.throws(() => new URL(), 'TypeError: Failed to construct URL: 1 argument required, but only 0 present.');
assert.throws(() => new URL(''), 'TypeError: Failed to construct URL: Invalid URL');
// Node 19.7
// https://github.com/nodejs/node/issues/46755
// assert.throws(() => new URL('', 'about:blank'), 'TypeError: Failed to construct URL: Invalid URL');
assert.throws(() => new URL('abc'), 'TypeError: Failed to construct URL: Invalid URL');
assert.throws(() => new URL('//abc'), 'TypeError: Failed to construct URL: Invalid URL');
Expand Down Expand Up @@ -115,6 +116,7 @@ QUnit.test('URL#href', assert => {
url = new URL('file:///var/log/system.log');
url.href = 'http://0300.168.0xF0';
// Node 19.7
// https://github.com/nodejs/node/issues/46755
// assert.same(url.href, 'http://192.168.0.240/', 'file -> http');
// assert.same(String(url), 'http://192.168.0.240/', 'file -> http');

Expand Down
2 changes: 2 additions & 0 deletions tests/unit-pure/web.url.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ QUnit.test('URL constructor', assert => {
assert.throws(() => new URL(), 'TypeError: Failed to construct URL: 1 argument required, but only 0 present.');
assert.throws(() => new URL(''), 'TypeError: Failed to construct URL: Invalid URL');
// Node 19.7
// https://github.com/nodejs/node/issues/46755
// assert.throws(() => new URL('', 'about:blank'), 'TypeError: Failed to construct URL: Invalid URL');
assert.throws(() => new URL('abc'), 'TypeError: Failed to construct URL: Invalid URL');
assert.throws(() => new URL('//abc'), 'TypeError: Failed to construct URL: Invalid URL');
Expand Down Expand Up @@ -116,6 +117,7 @@ QUnit.test('URL#href', assert => {
url = new URL('file:///var/log/system.log');
url.href = 'http://0300.168.0xF0';
// Node 19.7
// https://github.com/nodejs/node/issues/46755
// assert.same(url.href, 'http://192.168.0.240/', 'file -> http');
// assert.same(String(url), 'http://192.168.0.240/', 'file -> http');

Expand Down

0 comments on commit 1fc7ae4

Please sign in to comment.