Enahncing the build call to stream output to the terminal. #6
Conversation
|
Did a force push to squash it down to one commit. I had a lingering pry and didn't even add any rspecs. Should be good to go now. ^_^ |
lib/packer/client.rb
Outdated
| end | ||
|
|
||
| # @api private | ||
| # @param [Array<String>] args to pass to Packer | ||
| def command(args) | ||
| # @param Boolean set to true to stream output to $stdout | ||
| def command(args, stream = false) |
There was a problem hiding this comment.
Rather than a boolean to toggle streaming to stdout, how about a keyword argument that allows any IO object to be passed in, including $stdout, and defaults to nil to disable live streaming.
There was a problem hiding this comment.
Actually, that makes a lot more sense. I'll get it updated today.
|
Let me know if you want me to squash the commits before you merge. :-) |
|
Sorry for the delay. Been dealing with a move and some time crunches at work. :-) EDIT: Also did you want me to increment the gem version or did you want to handle that? |
|
No worries :) Happy to deal with the gem version. |
Streaming output to stdout helps with some CI servers that will time out long running commands with no output.