Add skipBodyHash check flag in verifyDkimSignature function #251
Conversation
|
Can you bump version by minor amount then we can release on NPM to use? |
sukhman-sukh
temporarily deployed
to
development
GitHub Actions
Inactive
sukhman-sukh
temporarily deployed
to
development
GitHub Actions
Inactive
|
Hey @sukhman-sukh Can you give some context on why this is needed? DKIM should pass even now for empty bodies. Did you run in to any issues? |
We need it since the archive needs to calculate email header without body access in order to reverse engineer keys, and often body hash calculation fails |
| @@ -180,7 +182,7 @@ export class DkimVerifier extends MessageParser { | |||
|
|
|||
| async finalChunk() { | |||
| try { | |||
| if (!this.headers || !this.bodyHashes.size) { | |||
| if ((!this.headers || !this.bodyHashes.size) && !this.skipBodyHash) { | |||
There was a problem hiding this comment.
How about (!this.headers || (!this.skipBodyHash && !this.bodyHashes.size))? (easier to read I guess)
There was a problem hiding this comment.
Yeah, I did the same but It was failing before, I fixed that but forgot to change it back.
Fixed.
sukhman-sukh
temporarily deployed
to
development
GitHub Actions
Inactive
sukhman-sukh
temporarily deployed
to
development
GitHub Actions
Inactive
This PR adds an optional flag for skipBodyHash and tests for pass on tampered body as well as bodyless emails with skipBodyHash=true.