perf: Faster cde rejection (prerequires #87) #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer the part we need to search over (last 64K of the file) so that we don't do a 4 byte read 65536 times.
Read large chunks of data at a time to dramatically cut down on syscalls. Add tests for various edge cases to validate.
…pr412a # Conflicts: # src/spec.rs
Pr0methean
added
the
waiting to be automatically merged
Pr0methean
changed the title
Pr0methean
added
waiting on another PR
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Pr0methean
added
waiting to be automatically merged
|
Rebased this PR because https://github.com/zip-rs/zip2/actions/runs/8945282269/job/24574475474?pr=85 wasn't going to finish before it timed out. |
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
|
Closing because this causes a severe performance regression in fuzz_read. |
auto-merge was automatically disabled
May 4, 2024 16:06
Pull request was closed
Pr0methean
removed
the
waiting to be automatically merged
|
Sorry I lost track of this, the pr moved several times. It's a significant improvement over the original code (in the 400x faster range)… Why didn't this get merged? Is there something I can do to help? |
|
Try redeveloping and retesting it against the current mainline. |
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Pr0methean
added
the
Please fix failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #47.