Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove executable bit #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wiiznokes
Copy link

The fact that this file is executable cause the cosmic-files package on fedora to fail to build. (https://copr.fedorainfracloud.org/coprs/ryanabx/cosmic-epoch/build/7922925/)

The error is as follows

ERROR: ./usr/src/debug/cosmic-files-0.1.0~^20240819git37933ce-1.fc40.aarch64/vendor/zip/src/spec.rs has shebang which doesn't start with '/' ([macro_use])

unfortunately, this specific file start with #[macro_use], which is interpreted as a miss form of #!/bin/*

This pr caused this issue #79

Apparently, its sometime the editor which automatically change the permission when it see a file starting with #

@cosmicexplorer i'm curious, what editor is in fault here 😆 ?

@cosmicexplorer
Copy link
Contributor

Thanks so much, I noticed this earlier and was surprised it hadn't broken anything. I think it is related to magit somehow which just released a new major version for the first time a long while and may have had some issues creep in. It started happening around February and I have been adding pre-commit hooks to work around it. I'm very sorry for causing this issue, it seems to have stopped occurring but I have added a pre-commit hook to my local checkout anyway to make sure. Thanks so much for stepping in to fix this.

@cosmicexplorer
Copy link
Contributor

It would make sense if this is because of the beginning # actually, I'll keep that in mind instead of blaming magit.

@wiiznokes
Copy link
Author

No problem! Imo, this shouldn't be a feature, or at least opt in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants