Multiple refactors #210
Merged
Multiple refactors #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1phyr
force-pushed
the
multiple_refactors
branch
from
ec351ef
to
6b0d79c
Compare
Pr0methean
requested changes
Jul 15, 2024
Pr0methean
added
the
Please address review comments
a1phyr
force-pushed
the
multiple_refactors
branch
from
f84c072
to
2e67999
Compare
a1phyr
removed
the
Please address review comments
Pr0methean
requested changes
Jul 17, 2024
Pr0methean
requested changes
Jul 19, 2024
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Pr0methean
added
the
waiting to be automatically merged
Pr0methean
approved these changes
Jul 19, 2024
Pr0methean
removed
the
waiting to be automatically merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiples refactors to improve
read.rs.Decompressortype (that we could even possibly make public)ZipFileand itscrypto_readerfieldmake_crypto_readerparametersEach commit can be reviewed separately.