Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor readers to use type parameters and not concrete vtables #207

Closed
wants to merge 18 commits into from
Closed

refactor readers to use type parameters and not concrete vtables #207

wants to merge 18 commits into from

Commits on Jul 16, 2024

  1. add ZipEntry API in src/unstable/read.rs 

    - also use git dep for zstd to pull in removal of R: BufRead bound
- move new methods into unstable/read.rs
- support getting aes verification info from a raw ZipEntry
- flesh out other methods from ZipFile -> ZipEntry
- now create a streaming abstraction
- move some methods around
    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    020a61a View commit details
    Browse the repository at this point in the history

  2. remove read_zipfile_from_stream()

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3abac52 View commit details
    Browse the repository at this point in the history

  3. fix up some public methods to use new impls

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b463f02 View commit details
    Browse the repository at this point in the history

  4. remove the old ZipFile API entirely

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f0faf24 View commit details
    Browse the repository at this point in the history

  5. remove a few more dyns

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    bf63d19 View commit details
    Browse the repository at this point in the history

  6. make AesModeInfo pub(crate) to make its intention clear

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3960e34 View commit details
    Browse the repository at this point in the history

  7. refactor streaming

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    27ba4d9 View commit details
    Browse the repository at this point in the history

  8. fmt and clippy

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9fee2c8 View commit details
    Browse the repository at this point in the history

  9. make ArchiveEntry more publicly accessible

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c360b15 View commit details
    Browse the repository at this point in the history

  10. allow(private_interfaces) -> allow(warnings)

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8c7cae1 View commit details
    Browse the repository at this point in the history

  11. fix impl trait return

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fb37849 View commit details
    Browse the repository at this point in the history

  12. fix private bounds on stable

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    872bd35 View commit details
    Browse the repository at this point in the history

  13. remove now-dead code

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fd11f28 View commit details
    Browse the repository at this point in the history

  14. fix for windows

    @cosmicexplorer
    cosmicexplorer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a28a43d View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Revert "remove now-dead code" 

    This reverts commit fd11f28.
    @cosmicexplorer
    cosmicexplorer committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    423a263 View commit details
    Browse the repository at this point in the history

  2. Revert "remove the old ZipFile API entirely" 

    This reverts commit f0faf24.
    @cosmicexplorer
    cosmicexplorer committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c83e9b6 View commit details
    Browse the repository at this point in the history

  3. Revert "remove read_zipfile_from_stream()" 

    This reverts commit 3abac52.
    @cosmicexplorer
    cosmicexplorer committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3259c5e View commit details
    Browse the repository at this point in the history

  4. remove unused

    @cosmicexplorer
    cosmicexplorer committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    bbee45b View commit details
    Browse the repository at this point in the history