-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #78: Implement diffing between values which have a common schema #79
Conversation
93778af
to
ddd0d9e
Compare
|
||
import zio.Chunk | ||
|
||
trait DiffAlgorithm[A] { self => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trait DiffAlgorithm[A] { self => | |
trait Differ[A] { self => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really amazing work. Will be useful in so many different ways (e.g. json patching, data ETL, etc.).
Might need a few more unit tests but this is good to go I think now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful work. ❤️
…hema (zio#79) * Remove setup gpg * Update setup-java * Test * test2 * test 3 * Fixes zio#78: Implement diffing between instances described by a schema * Specs and additional implementations * Rename DiffAlgorithm to Differ * Add diffs for product and sum types * Copy Myers diff implementation from zio-test * Implement binary diff and unit tests * Fix various temporal diffs and add unit tests * formatting * Test coverage and tweaks * Alphabetical sorting and comments on diff method Co-authored-by: thinkharder <thinkharderdev@users.noreply.github.com>
This is still a WIP but the design is (mostly) done.
This will implement diffing between values of type
A
when aSchema[A]
is available.