Fixes #45: Capture annotations in record schemas #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jdegoes
reviewed
May 17, 2021
| } | ||
|
|
||
| final case class GenericRecord(override val structure: ListMap[String, Schema[_]]) extends Record[ListMap[String, _]] | ||
| final case class GenericRecord(override val structure: Seq[Field[_]]) extends Record[ListMap[String, _]] |
There was a problem hiding this comment.
It's ok for Seq to appear in contravariant position (as an input to a method), but it should not appear in covariant position (as an output from a method) because it provides no Big Oh guarantees on any of its methods.
Instead, I suggest we refactor this to be Chunk[Field[_]] here and elsewhere, so that users have guaranteed O(1) random access, etc.
jdegoes
reviewed
May 17, 2021
|
|
||
| sealed trait Record[R] extends Schema[R] { | ||
| def structure: Seq[Field[_]] | ||
| def annotations: Seq[Any] = Nil |
There was a problem hiding this comment.
Ditto for all covariant uses of Seq.
jdegoes
approved these changes
May 17, 2021
|
@thinkharderdev Thanks for your work on this! One step closer to the Ultimate Goal. |
landlockedsurfer
pushed a commit
to landlockedsurfer/zio-schema
that referenced
this pull request
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
Capture annotations in
Recordschemas:Schema.Field[A]type to encapsulate fields inRecordschemaSeq[Schema.Field[_]]instead ofListMap[String,Schema[_]]. By usingListMapwe lose O(1) lookups anyway so this seemed like the better encoding.