Added new methods for Validation #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoo
reviewed
Dec 26, 2023
| @@ -4,6 +4,13 @@ sealed trait Bool[A] { self => | |||
| def &&(that: Bool[A]): Bool[A] = Bool.And(self, that) | |||
| def ||(that: Bool[A]): Bool[A] = Bool.Or(self, that) | |||
| def unary_! : Bool[A] = Bool.Not(self) | |||
|
|
|||
| def map[B](f: A => B, notCounter: Int = 0): Bool[B] = self match { | |||
There was a problem hiding this comment.
This notCounter parameter is not used for anything
vigoo
reviewed
Dec 26, 2023
| type Errors = Chunk[ValidationError] | ||
| type Result = Either[Errors, Errors] | ||
| def validate(value: A): Result | ||
| def premap[B](f: B => A): Predicate[B] = Predicate.Premap(Bool.Leaf(self), f) |
There was a problem hiding this comment.
Shouldn't this called contramap?
There was a problem hiding this comment.
Yes, you are right! Fixed this and the counter.
jdegoes
reviewed
Jan 8, 2024
| } | ||
| } | ||
|
|
||
| final case class Contramap[B, A](pred: Bool[Predicate[A]], f: (B => A)) extends Predicate[B] { |
There was a problem hiding this comment.
Storing a Scala function inside Contramap may complicate the story of converting a validation into a JSON Spec. Is contramap strictly required?
There was a problem hiding this comment.
Not really, but I think that using typeclasses and implicits can solve that while allowing for composability and customization. Some libraries also allow for a custom validation, which might be a nice addition in this direction. What do you think?
jdegoes
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods to create Validations for
OptionandEithertypes. It also allows to create new validations with methodpremap. Adresses #588.Use: