Implement protobuf codec for case class schemas #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkharderdev
commented
Apr 24, 2021
| JsonCodec.Encoder.charSequenceToByteChunk("""{"value":{"string":"foo"}}""") | ||
| JsonCodec.Encoder.charSequenceToByteChunk("""{"oneOf":{"StringValue":{"value":"foo"}}}""") |
There was a problem hiding this comment.
@jdegoes I'm not 100% sure about this but I think the encoding before was wrong w/r/t case classes with ADT fields. Not sure if the way it was implemented was just an optimization though....
thinkharderdev
commented
Apr 24, 2021
| } yield assert(e)(equalTo("0A03466F6F107B")) && assert(e2)(equalTo("0A03466F6F107B")) | ||
| }, | ||
| testM("enumerations") { | ||
| for { | ||
| e <- encode(schemaEnumeration, Enumeration(IntValue(482))).map(toHex) | ||
| e2 <- encodeNS(schemaEnumeration, Enumeration(IntValue(482))).map(toHex) | ||
| } yield assert(e)(equalTo("0A0310E203")) && assert(e2)(equalTo("0A0310E203")) | ||
| } yield assert(e)(equalTo("0A05120308E203")) && assert(e2)(equalTo("0A05120308E203")) |
There was a problem hiding this comment.
Same thing here as above.
jdegoes
previously approved these changes
Apr 26, 2021
|
@thinkharderdev Looks good to merge after the conflict is fixed! |
jdegoes
approved these changes
Apr 26, 2021
|
Thanks for your work on this! Protobuf continues to improve. |
landlockedsurfer
pushed a commit
to landlockedsurfer/zio-schema
that referenced
this pull request
May 28, 2022
* Implement protobuf codec for case class schemas * Add cases for all case class arities * resolve merge issue Co-authored-by: thinkharder <thinkharderdev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.