Scala3: Improve exclusion rules and DRY pprint dependency #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use same version of scala-collection-compat everywhere Dry usages of pprint
lolgab
force-pushed
the
fix-pprint-and-exclusions
branch
from
e546119 to
6711859
Compare
guizmaii
approved these changes
Sep 6, 2023
guizmaii
changed the title
|
Thanks for your work @lolgab! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
quill-utilmisses some classes which makes it unusable standalone with Scala 3 without providing the missing dependencies.Solution
Manually add the Scala 3 version of the excluded libraries.
Also adds the pprint dependency only where used so it's not added to all modules
@getquill/maintainers