Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the "==" constraint to a.i == b.i in PrepareSpec."with outer join" #2230

Merged
merged 11 commits into from
Oct 19, 2023

Conversation

b-gyula
Copy link
Contributor

@b-gyula b-gyula commented Aug 9, 2021

Problem

Test case PrepareSpec."with outer join" was creating a meaningless join (a, b) <- qr1 join qr2 on ((a, b) => a.i == a.i)

Solution

Fixed the "==" constraint to a.i == b.i

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@b-gyula b-gyula changed the title - Added support for onConflictIgnore to H2 (v1.4.200 in PostgreSQL mode) - Doc updated with database actions return values Fixed the "==" constraint to a.i == b.i in PrepareSpec."with outer join" Aug 9, 2021
@b-gyula b-gyula marked this pull request as ready for review August 9, 2021 14:31
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2022

CLA assistant check
All committers have signed the CLA.

@guizmaii guizmaii merged commit 07dbbd7 into zio:master Oct 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants